Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

Devin PR requested by @petebacondarwin

Resolves peer dependency warnings that appear when running pnpm i. The warnings were:

  1. @microlabs/otel-cf-workers requiring @opentelemetry/api@~1.9.0 but finding 1.7.0
  2. vitest@3.0.9 requiring @vitest/ui@3.0.9 but finding 3.2.3
  3. @tailwindcss/vite and @vitejs/plugin-react requiring Vite 5/6 but finding 7.0.0
  4. @vitejs/plugin-basic-ssl requiring Vite 6 but finding 7.0.0
  5. @cloudflare/types requiring React 15-17 but finding React 19

Changes:

  • Add @opentelemetry/api@^1.9.0 to vitest-pool-workers-examples fixture
  • Update vitest to catalog:default in vitest-pool-workers-remote-bindings fixture to match workspace version
  • Update @tailwindcss/vite to ^4.1.17, @vitejs/plugin-react to ^5.1.2, and @vitejs/plugin-basic-ssl to ^2.1.0 for Vite 7 compatibility
  • Extend peerDependencyRules.allowedVersions to accept React 18 and 19

Human review checklist:

  • Verify @vitejs/plugin-react v4→v5 upgrade doesn't break playground functionality
  • Confirm React 19 allowance in peerDependencyRules is intentional

  • Tests
    • Tests not necessary because: changes only affect test fixtures, playgrounds, and peerDependencyRules configuration - existing tests cover this functionality
  • Public documentation
    • Documentation not necessary because: internal dependency updates only
  • Wrangler V3 Backport
    • Not necessary because: these are fixture/playground dependency updates, not Wrangler changes

Link to Devin run

- Add @opentelemetry/api@^1.9.0 to fixtures/vitest-pool-workers-examples to satisfy @microlabs/otel-cf-workers peer dep - Update vitest to catalog:default in fixtures/vitest-pool-workers-remote-bindings to match @vitest/ui version - Update @tailwindcss/vite to ^4.1.17 for Vite 7 compatibility - Update @vitejs/plugin-react to ^5.1.2 for Vite 7 compatibility - Update @vitejs/plugin-basic-ssl to ^2.1.0 for Vite 7 compatibility - Update peerDependencyRules to allow React 18 and 19 for @cloudflare/types compatibility Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: e61528f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11574 

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11574 

miniflare

npm i https://pkg.pr.new/miniflare@11574 

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11574 

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11574 

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11574 

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11574 

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11574 

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11574 

wrangler

npm i https://pkg.pr.new/wrangler@11574 

commit: e61528f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant