Skip to content

Un-quarantine C3 e2e test for redwood #11573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dario-piotrowicz wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −5
Draft

Un-quarantine C3 e2e test for redwood #11573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6c4a7a
Un-quarantine C3 e2e test for redwood
dario-piotrowicz Dec 9, 2025
75130b5
Try prefixing wrangler package version with `^`
dario-piotrowicz Dec 9, 2025
17dbaeb
Try to force-install wrangler@latest
dario-piotrowicz Dec 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/create-cloudflare/e2e/tests/frameworks/test-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,6 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
},
{
name: "redwood",
// quarantined while we investigate CI failures
quarantine: true,
testCommitMessage: true,
timeout: LONG_TIMEOUT,
unsupportedOSs: ["win32"],
Expand Down
19 changes: 16 additions & 3 deletions packages/create-cloudflare/src/helpers/packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ type InstallConfig = {
startText?: string;
doneText?: string;
dev?: boolean;
force?: boolean;
};

/**
Expand All @@ -21,6 +22,7 @@ type InstallConfig = {
* @param config.dev - Add packages as `devDependencies`
* @param config.startText - Spinner start text
* @param config.doneText - Spinner done text
* @param config.force - Add `--force` flag
*/
export const installPackages = async (
packages: string[],
Expand Down Expand Up @@ -51,10 +53,21 @@ export const installPackages = async (
break;
}

await runCommand([npm, cmd, ...(saveFlag ? [saveFlag] : []), ...packages], {
...config,
const { force, ...commandConfig } = config;

await runCommand(
[
npm,
cmd,
...(saveFlag ? [saveFlag] : []),
...(force ? ["--force"] : []),
...packages,
],
{
...commandConfig,
silent: true,
});
},
);

if (npm === "npm") {
// Npm install will update the package.json with a caret-range rather than the exact version/range we asked for.
Expand Down
9 changes: 9 additions & 0 deletions packages/create-cloudflare/templates/redwood/c3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { logRaw } from "@cloudflare/cli";
import { runFrameworkGenerator } from "frameworks/index";
import { detectPackageManager } from "helpers/packageManagers";
import { installPackages } from "helpers/packages";
import type { TemplateConfig } from "../../src/templates";
import type { C3Context } from "types";

Expand All @@ -9,6 +10,14 @@ const { npm } = detectPackageManager();
const generate = async (ctx: C3Context) => {
await runFrameworkGenerator(ctx, [ctx.project.name]);

// Note: for redwood projects we need to force install the latest version of wrangler
// if we don't do the CI npm e2e fails to install the app's dependencies
// (we couldn't reproduce this locally, but it can possibly happen to users as well?)
await installPackages([`wrangler@latest`], {
dev: true,
force: true,
});

logRaw("");
};

Expand Down
Loading