- Notifications
You must be signed in to change notification settings - Fork 1k
Do not override any .env settings in .gitignore files #10766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 293edad The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
vicb left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit & changeset say:
do not override .env settings in .gitignore files
but IIUC this is an existing feature that is being fixed by updating the regexp?
If that is the case, could we update the decsriptions to reflect this?
3d8913a to 3f60fcb Compare .env settings in .gitignore files
Done |
vicb left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the update (two inline typo fixes)
Should <local|production|staging> be <local|production|staging|...> instead?
i.e. it could be "test" or anything else
9d30d71 to 293edad Compare
Previously we only looked for
.env*in thegitignorebut now we cover more cases such as:.env.env\*.env.<local|production|staging>.env\*.<local|production|staging>Fixes #10749