Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Sep 25, 2025

Previously we only looked for .env* in the gitignore but now we cover more cases such as:

  • .env
  • .env\*
  • .env.<local|production|staging>
  • .env\*.<local|production|staging>

Fixes #10749


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: create-cloudflare not backported
@petebacondarwin petebacondarwin requested a review from a team as a code owner September 25, 2025 16:40
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 293edad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 25, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 25, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10766 

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10766 

miniflare

npm i https://pkg.pr.new/miniflare@10766 

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10766 

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10766 

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10766 

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10766 

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10766 

wrangler

npm i https://pkg.pr.new/wrangler@10766 

commit: 293edad

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit & changeset say:

do not override .env settings in .gitignore files

but IIUC this is an existing feature that is being fixed by updating the regexp?
If that is the case, could we update the decsriptions to reflect this?

@petebacondarwin petebacondarwin force-pushed the pbd/c3/fix-dot-env-updating branch from 3d8913a to 3f60fcb Compare September 29, 2025 19:59
@petebacondarwin petebacondarwin changed the title do not override .env settings in .gitignore files Do not override any .env settings in .gitignore files Sep 29, 2025
@petebacondarwin
Copy link
Contributor Author

The commit & changeset say:

do not override .env settings in .gitignore files

but IIUC this is an existing feature that is being fixed by updating the regexp? If that is the case, could we update the decsriptions to reflect this?

Done

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the update (two inline typo fixes)

Should <local|production|staging> be <local|production|staging|...> instead?

i.e. it could be "test" or anything else

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 30, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/c3/fix-dot-env-updating branch from 9d30d71 to 293edad Compare September 30, 2025 12:51
@petebacondarwin petebacondarwin merged commit bd5b720 into main Oct 1, 2025
50 of 54 checks passed
@petebacondarwin petebacondarwin deleted the pbd/c3/fix-dot-env-updating branch October 1, 2025 08:39
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

2 participants