Skip to content

Conversation

@eshentials
Copy link

Fixes #10646.

Improve custom build error handling in dev mode to match non-custom build behavior:

  1. Initial Build Failures:

    • Exit immediately with error code 1 if the initial build fails
    • Provide clear error messages explaining the build failure
  2. Development Build Failures:

    • Continue running the dev server when builds fail during development
    • Return 500 errors for requests when the build is in a failed state
    • Show clear error messages in both console and HTTP responses
  3. Error Recovery:

    • Automatically recover when build issues are fixed
    • Clear error state and resume normal operation
  4. Testing:

    • Added unit tests for build failure scenarios
    • Added E2E test to verify the complete flow
    • Ensured tests clean up properly

  • Tests

    • Tests included
      • Unit tests for build failure scenarios
      • E2E test for complete flow verification
    • Tests not necessary because:
  • Public documentation

    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is an internal behavior improvement
  • Wrangler V3 Backport

    • Wrangler PR:
    • Not necessary because:
@eshentials eshentials requested a review from a team as a code owner September 21, 2025 13:03
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2025

⚠️ No Changeset found

Latest commit: 00a89a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eshentials
Copy link
Author

@dario-piotrowicz Hi, pls review.

@eshentials
Copy link
Author

eshentials commented Oct 1, 2025

@dario-piotrowicz Hi, any update ? @zwily

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Oct 1, 2025

Hi @eshentials , sorry for the late reply

Your PR contains various changes that seem completely unrelated to #10646, could you double check your changes and make sure that the PR only contains what's related to the issue it's trying to address?

Also the PR description says that an E2E test has been added, but none is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants