fix: cloudflare_workers_script run_worker_first accepts list input #6178
Conversation
There was a problem hiding this comment.
Hi @maxwellpeterson,
Thanks for the PR! I wanted to flag that there still seems to be an issue with the config property inside assets. When using a config block, the provider fails with a conversion error (see my comment here
).
It would be great if this PR could take that scenario into account to ensure the provider correctly handles the config block with both boolean and list values.
Thanks!
| @aashishshrestha09 the bug you ran into was due to a mismatch between the attribute type within the model and schema. Sorry for the trouble here. This PR handles both |
Hi @1000hz, Thank you for clarifying! That makes sense. Once this PR is merged, will the fix be available immediately in a v5.10.1 patch release, or will we need to wait for the next provider release (v5.11.0) to use it in Terraform? Thanks again! Also, I’ve detected another issue with the assets block and have created a bug report here. |
maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from c515531 to c2860d8 Compare 
| Can you target next please? And make sure its branched off next too. |
maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from 7cf72a8 to 82c4243 Compare 
stainless-app bot force-pushed the next branch from c2f1e45 to ee69b71 Compare maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 2 times, most recently from d749e65 to 13945ad Compare stainless-app bot force-pushed the next branch 2 times, most recently from 49bbfc7 to 618db3c Compare maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 4 times, most recently from 795436c to d7029b1 Compare maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 6 times, most recently from 0307d26 to 703136b Compare stainless-app bot force-pushed the next branch from 3b7bdd4 to d156eef Compare maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from 703136b to e559756 Compare 
vaishakdinesh requested review from SirCortly, mgirouard, musa-cf, rotem-cloud, ssicard and tamas-jozsa maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 2 times, most recently from 3c91e52 to b3fa633 Compare stainless-app bot force-pushed the next branch from 44843f0 to 057b6a7 Compare 
| lgtm |
musa-cf force-pushed the next branch 2 times, most recently from 8419486 to d301974 Compare stainless-app bot force-pushed the next branch from 4c8915d to 9cc9eee Compare | @maxwellpeterson Do we still need this? I think these changes are already in? |
stainless-app bot force-pushed the next branch from b026b4d to 262c3dd Compare 
… list input - This property can either be a boolean or list of strings, the API accepts both - Update resource to accept list of strings in addition to boolean values
mgirouard force-pushed the mpeterson/run-worker-first-list branch from b3fa633 to 9a99eac Compare 
| Hey @maxwellpeterson I rebased your PR and it looks like there's no diff. I think other patches may have take care of this already maybe? |
5 participants
Changes being requested
assets.config.run_worker_firstproperty ofcloudflare_workers_scriptresource to accept list of strings in addition to boolean inputAdditional context & links
Fixes #5956