Skip to content

Late Spring cleaning of Node lib indexing #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 22, 2023
Merged

Late Spring cleaning of Node lib indexing #209

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3bbfbdb
* add cljs.foreign.node ns
swannodette May 19, 2023
54afe7a
* document add-exports
swannodette May 19, 2023
f0ad84f
* more refactoring
swannodette May 19, 2023
0ddb7c4
* more test stuff
swannodette May 19, 2023
f793612
* clarifying docs / comments about the existing code
swannodette May 19, 2023
fb99871
* more clarifying comments, refactor
swannodette May 19, 2023
7a34d2a
* fix up recursive delete
swannodette May 19, 2023
3f34a4c
* breakout get-pkg-json to simplify testing
swannodette May 19, 2023
7c2c8a3
* test helpers
swannodette May 19, 2023
b3ae4b9
* reuse existing deletion stuff
swannodette May 19, 2023
d1a181f
* thread in opts
swannodette May 22, 2023
ae12bf6
* basic export subpath support, test
swannodette May 22, 2023
8854b6f
* remove TODOs
swannodette May 22, 2023
a6534bb
* don't exclude .cjs files
swannodette May 22, 2023
a66ea16
* fix comment
swannodette May 22, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
* fix comment
  • Loading branch information
@swannodette
swannodette committed May 22, 2023
commit a66ea16093ced62d2dd2d626ea79536aca4ecbdd
8 changes: 5 additions & 3 deletions src/main/clojure/cljs/foreign/node.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,11 @@
;; NOTE: ignore "." exports for now
(if (= "." export-subpath)
pkg-jsons
;; if a package.json exists at the export add
;; FIXME: technically this logic is a bit brittle since `exports` is used
;; to hide the package structure.
;; technically the following logic is a bit brittle since `exports` is
;; supposed to be used to hide the package structure.
;; instead, here we assume the export subpath does match the library structure
;; on disk, if we find a package.json we add it to pkg-jsons map
;; and we synthesize "name" key based on subpath
(let [export-pkg-json (->export-pkg-json path export-subpath)]
;; note this will ignore export wildcards etc.
(cond-> pkg-jsons
Expand Down