Skip to content

CLJS-3399: :as-alias does not work with symbols #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2023
Merged

CLJS-3399: :as-alias does not work with symbols #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/clojure/cljs/analyzer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,8 +917,11 @@
([env name]
(resolve-ns-alias env name (symbol name)))
([env name not-found]
(let [sym (symbol name)]
(get (:requires (:ns env)) sym not-found))))
(let [sym (symbol name)
{:keys [requires as-aliases]} (:ns env)]
(or (get requires sym)
(get as-aliases sym)
not-found))))

(defn resolve-macro-ns-alias
([env name]
Expand Down
7 changes: 6 additions & 1 deletion src/test/cljs/cljs/ns_test.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
[cljs.test]
[cljs.ns-test.foo :refer [baz]]
[clojure.set :as s :refer [intersection] :rename {intersection itsc}]
[cljs.analyzer :as ana])
[cljs.analyzer :as ana]
[fake.ns :as-alias fake])
(:use [cljs.ns-test.bar :only [quux]]))

(def + -)
Expand Down Expand Up @@ -43,3 +44,7 @@
(is (.isArrayLike js/goog array-like))
(is (goog/isArrayLike array-like))
(is (goog-alias/isArrayLike array-like))))

(deftest test-cljs-3399
(is (= ::fake/foo :fake.ns/foo)
(= `fake/foo `fake.ns/foo)))