Run clj file as script & evaluate expression #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Nice work! |
erkkikeranen suggested changes May 15, 2020
src/user_action.rs Outdated
| } | ||
| } | ||
| | ||
| pub fn parse_args() -> Action{ |
Member
There was a problem hiding this comment.
Change this fn so that it takes the Vec env variables as input
src/main.rs Outdated
| // | ||
| // Start repl | ||
| // | ||
| let cli_args: user_action::Action = user_action::parse_args(); |
Member
There was a problem hiding this comment.
Change to user_action::parse_args( env::args().collect() );
src/user_action.rs Outdated
| | ||
| pub fn parse_args() -> Action{ | ||
| | ||
| let arguments: Vec<String> = env::args().collect(); |
Member
There was a problem hiding this comment.
Now this can be removed,
So you can write trivial unit tests for the cases (Runscript, Evaluate and Nothing) to check that parse_args return correct enum
erkkikeranen suggested changes May 16, 2020
src/user_action.rs Outdated
| use crate::user_action; | ||
| | ||
| #[test] | ||
| fn parse_args_test() { |
Member
There was a problem hiding this comment.
You could group these test under a
mod parse_args_tests, and under that mod have one test per assertion, ie.
fn parses_args_given_path just asserts what it describes
you can see examples in other files, this makes nice and organized and descriptive test output and it’s also easy to run certain tests
erkkikeranen approved these changes May 16, 2020
Tko1 approved these changes May 16, 2020
Hardcoding based on arguments.len() == 3 for now Examples: --init/-i for script or --eval/-e for evaluate expression cargo run -- --init examples/hello_world.clj cargo run -- --eval "(println \"eh\")" cargo run -- --eval "(+ 1 2)"
Changing output of cargo run -- --eval "(+ 1 2)" from I32(3) to 3
…le (and fixed some formatting)
Tko1 force-pushed the feature/run-clj-file-as-script branch from ee6b46c to ee27d1a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hardcoding based on arguments.len() == 3 for now
Examples:
--init/-i for script or --eval/-e for evaluate expression
cargo run -- --init examples/hello_world.clj
cargo run -- --eval "(println \"eh\")"
cargo run -- --eval "(+ 1 2)"