Use lexical-binding in parseclj-lex.el as well #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the PR! While I'd imagine that this would pass 99 out of 100 times, I would err on the side of cautiousness and leave it as-is. Especially as parseclj/parseedn move at a slower pace. |
| Meanwhile, could you please add |
| Got it, TIL. Feel free to add it and I'll merge it in! |
tarsius added a commit to tarsiiformes/parseclj that referenced this pull request Dec 3, 2023
This silence Emacs 30's byte-compiler, which insists on this variable being set in every file. Stick to not enabling lexical-bindings for now, see clojure-emacs#41.
| I've updated the commit. |
| Ups, one moment please. Listening to Emacsconf talks while coding... |
This silence Emacs 30's byte-compiler, which insists on this variable being set in every file. Stick to not enabling lexical-bindings for now, see clojure-emacs#41.
| Good to go now 😁 |
| Thanks! I'll cut a release. A stable CIDER release including it may not be created until later next week. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.