Skip to content

Conversation

plexus
Copy link
Collaborator

@plexus plexus commented Oct 11, 2021

Users are reporting issues with cl-case, depending on the Emacs version and
build.

See clojure-emacs/cider#2967

Users are reporting issues with `cl-case`, depending on the Emacs version and build.
@plexus
Copy link
Collaborator Author

plexus commented Oct 11, 2021

Did we not have CI on these repos previously? Running tests locally for now but if we continue to poke at these things we should probably set that up again.

@bbatsov
Copy link
Member

bbatsov commented Oct 11, 2021

Won't pcase be a better fit for some of those use cases?

@plexus
Copy link
Collaborator Author

plexus commented Oct 11, 2021

So pcase == condp? shakes fist at elisp I spent like ten minutes trying to figure out if there was a condp. We really need a clojure.core -> emacs-lisp cheat sheet. (I know there's this big lisp comparison table, but it does not contain equivalents for everything in clojure.core.)

Anyway yes pcase probably would've been better but I'm going to leave this as is.

@bbatsov
Copy link
Member

bbatsov commented Oct 11, 2021

Fine by me. We can always change this down the road.

@plexus plexus merged commit adb55fa into master Oct 13, 2021
@plexus plexus deleted the cl-case-to-cond branch October 13, 2021 04:42
@plexus plexus mentioned this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants