error on unmatched closing paren/brace #26
Conversation
| Hi @ikappaki, sorry for the slow response. This got snowed under in my inbox. I think this looks good, but could you fix the indentation? I'll leave some comments inline. |
parseclj-parser.el Outdated
| (parseclj-lex-token-type closing-token)) | ||
| | ||
| (reverse collection))))) | ||
| (fail-fast (a-get options :fail-fast t))) |
There was a problem hiding this comment.
These let bindings should be aligned as before, if you let Emacs reindent it it should do it correctly.
There was a problem hiding this comment.
It's due to literal tabs, I'll revert to spaces and set indent-tabs-mode in .dir-locals accordingly
parseclj-parser.el Outdated
| | ||
| stack) | ||
| | ||
| (let ((collection nil)) |
There was a problem hiding this comment.
Is it necessary to pull this into a separate let? if not I would leave it where it was.
There was a problem hiding this comment.
Not necessary, but just because its scope has moved a level down into the else part; I'll restore it and replace with progn instead.
| (parseclj-parse-clojure "'(1))") | ||
| (parseclj-parser-error (cadr errdata))) | ||
| "At position 5, unmatched :rparen")) | ||
| ) |
There was a problem hiding this comment.
Thanks for the review
| Thanks! I've updated the CHANGELOG and tagges this as |
2 participants
Please consider patch to raise error when there are unmached closing parentheses or braces.
Test added for both of these, as well as for :fail-fast nil.