Skip to content

Fix parseclj-lex-character for \u and \o #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2017
Merged

Fix parseclj-lex-character for \u and \o #11

merged 2 commits into from
Nov 24, 2017

Conversation

volrath
Copy link
Member

@volrath volrath commented Nov 24, 2017

Current behavior when reading a string like: "\u \v \w" is to produce only two character tokens:

((:node-type . :character) (:position . 1) (:form . "\\u \\v ") (:value . 0)) ((:node-type . :character) (:position . 6) (:form . "\\w") (:value . 119))

Included a test that ensures proper token generation.
@volrath
Remove duplicated test
e65eb08
@volrath
Fix test case for \u and \o characters
388bb2b 
Before this commit, reading something like "\u \v \w", would produce two char tokens, one with "\u \v " and another with "\w". Test included exemplifies solution.
@plexus plexus merged commit 9c1f379 into docstrings-and-conventions Nov 24, 2017
@vemv vemv deleted the parseclj-lex-character-fix branch September 11, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@volrath @plexus