Skip to content

Conversation

IrrenWirr
Copy link
Contributor

@IrrenWirr IrrenWirr commented May 7, 2025

nasty (check-parens)
it mess up marks selection in my idiosyncratic config of emacs

i.e when activating a mark, then moving around, and suddenly cider-completion-get-info-context-at-point' get triggered by a timer, and mess-up my desired mark-region by another mark-region created from a mix of my starting point of activating mark and then end point of check-parens'

So I put it in (save-mark-and-excursion) instead of only (save-excursion)

The only one that was messing with my usage was in "cider-completion-get-info-context-at-point"

but who knows, maybe "cider-completion-get-context-at-point" also mess someone's emacs usage

So to be safe, did it to both, also because kinda hard to pinpoint the issue from a user perspective with an emacs loaded full of so many modes & customization, because its triggered by a timer...


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

nasty (check-parens) it mess up marks selection in my idiosyncratic config of emacs So I put it in (save-mark-and-excursion) instead of only (save-excursion) The only one that was messing with my usage was in "cider-completion-get-info-context-at-point" but who knows, maybe "cider-completion-get-context-at-point" also mess someone's emacs usage So to be safe, did it to both
@alexander-yakushev
Copy link
Member

Looks reasonable to me. Thanks!

@alexander-yakushev alexander-yakushev merged commit f83d768 into clojure-emacs:master May 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants