[Inspector] Reimplement point retention between inspector screen changes

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Changes
 
 - [#3777](https://github.com/clojure-emacs/cider/issues/3777): Inspector no longer displays parsed Javadoc for Java classes and members.
+- [#3784](https://github.com/clojure-emacs/cider/issues/3784): Inspector: make point less erratic when navigating between inspector screens.
 
 ## 1.17.1 (2025-02-25)
 

cider-connection.el

@@ -938,6 +938,12 @@ function with the repl buffer set as current."
  (user-error "No %s REPLs in current session \"%s\""
  type (car (sesman-current-session 'CIDER)))))
 
+(defvar-local cider--ancillary-buffer-repl nil
+ "Special buffer-local variable that contains reference to the REPL connection.
+This should be set in ancillary CIDER buffers that originate from some
+event (e.g. *cider-inspector*, *cider-error*) and which never change the
+REPL (connection) which produced them.")
+
 (defun cider-current-repl (&optional type ensure)
  "Get the most recent REPL of TYPE from the current session.
 TYPE is either clj, cljs, multi or any.
@@ -951,17 +957,18 @@ no linked session or there is no REPL of TYPE within the current session."
  (eq cider-repl-type type)))
  ;; shortcut when in REPL buffer
  (current-buffer)
- (let* ((type (or type (cider-repl-type-for-buffer)))
- (repls (cider-repls type ensure))
- (repl (if (<= (length repls) 1)
- (car repls)
- ;; pick the most recent one
- (seq-find (lambda (b)
- (member b repls))
- (buffer-list)))))
- (if (and ensure (null repl))
- (cider--no-repls-user-error type)
- repl)))))
+ (or cider--ancillary-buffer-repl
+ (let* ((type (or type (cider-repl-type-for-buffer)))
+ (repls (cider-repls type ensure))
+ (repl (if (<= (length repls) 1)
+ (car repls)
+ ;; pick the most recent one
+ (seq-find (lambda (b)
+ (member b repls))
+ (buffer-list)))))
+ (if (and ensure (null repl))
+ (cider--no-repls-user-error type)
+ repl))))))
 
 (defun cider--match-repl-type (type buffer)
  "Return non-nil if TYPE matches BUFFER's REPL type."

cider-debug.el

@@ -683,8 +683,7 @@ needed. It is expected to contain at least \"key\", \"input-type\", and
  (setq cider--debug-mode-response response)
  (cider--debug-mode 1)))
  (when inspect
- (setq cider-inspector--current-repl (cider-current-repl))
- (cider-inspector--render-value inspect)))
+ (cider-inspector--render-value inspect :next-inspectable)))
  ;; If something goes wrong, we send a "quit" or the session hangs.
  (error (cider-debug-mode-send-reply ":quit" key)
  (message "Error encountered while handling the debug message: %S" e)))))