Skip to content

Conversation

@yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Apr 29, 2022

Here are some non-user-visible changes and bugs I've discovered and fixed in the past. Most should be self explanatory, in particular the cider-eval-to-comment bug concerns multiline output in (comment) forms, which currently produces:

(comment (repeat 5 "long lines of text for multiline pprint") ;; => ("long lines of text for multiline pprint" ;; "long lines of text for multiline pprint" ;; "long lines of text for multiline pprint" ;; "long lines of text for multiline pprint" ;; "long lines of text for multiline pprint") )

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

yuhan0 added 11 commits April 29, 2022 20:36
to avoid overwriting the last evaled result
Defun bounds always include the following newline, except for the edge case at the end of buffer. This causes cider-eval-defun-to-comment to insert the comment at the end of line instead of on a new line.
Remove the "q" keybinding which is already defined in cider-popup-mode-map
@bbatsov bbatsov merged commit 5073237 into clojure-emacs:master Apr 29, 2022
@bbatsov
Copy link
Member

bbatsov commented Apr 29, 2022

Here are some non-user-visible changes and bugs I've discovered and fixed in the past.

Some of them seem user-visible to me. :-) That being said - great collection of bug-fixes! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants