Fix error in cider-clojuredocs-lookup #3163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Issue: cider-clojuredocs pops the doc buffer but then still asks you for a symbol. Maybe only with emacs master highlight-regexp might have changed. The issue is that cider-clojuredocs-lookup passes nil to highlight-regexp, which then throws an error. and cider-try-symbol-at-point handles all errors with asking for a symbol.
vemv reviewed Mar 1, 2022
| (highlight-regexp | ||
| (regexp-quote | ||
| (or (cadr (split-string sym "/")) | ||
| sym)) |
There was a problem hiding this comment.
Could be desirable to extract this one to defun and then unit-test it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue:
cider-clojuredocs pops the doc buffer
but then still asks you for a symbol.
The issue is that
cider-clojuredocs-lookup passes nil to highlight-regexp,
which then throws an error.
It's only an issue when sym doesn't have a
/.and upstream cider-try-symbol-at-point handles all errors with
asking for a symbol.
Also
symcan be something like.at this point so calling regexp-quote makes sense.