Translate paths from CIDER to nREPL and vice-versa

[iarenaza]

When cider-path-translations is in use (e.g., when CIDER is running
on the host, but the nREPL is running in a virtual machine or a
container) we need to translate from the host "CIDER-based" paths to
the container "nREPL-based" paths and vice-versa, depending on the
operation.

Translations from "nREPL-based" paths to "CIDER-based" paths were
already implemented, but not the other way around. Some operations in
clj-refactor need the "CIDER-based"to "nREPL-based" path translations
to work correctly (e.g., cljr-rename-file-or-dir,
cljr-rename-symbol, etc.).

This patch implements the missing path translations, and is a
pre-requisite for the complementary clj-refactor patch that is
proposed separately.

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.

[bbatsov]

The changes look good to me overall, but if this is going to be public API used by other packages the functions shouldn't have -- in their names. I also think we can expand the relevant documentation.

[iarenaza]

Hi @bbatsov

I didn't intend any of the new functions to be public. I saw them as just internal implementation details for cider-from-nrepl-filename-function and cider-to-nrepl-filename-function, which I thought was the public API for this functionality. Do you want them to be public?

Regarding the documentation expansion, do you mean the functions documentation or other kind of documentation?

[bbatsov]

In Emacs Lisp we normally use symbols instead of keywords - e.g. 'from-nrepl.

[bbatsov]

Don't forget the final ..

[bbatsov]

My bad. I misread the implementation.

[bbatsov]

Thanks for tackling this!