Skip to content

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Mar 11, 2025

Two changes here:

  1. I extracted the mechanism of binding a specific REPL connection to an inspector buffer into a separate variable in cider-connection.el and taught (cider-current-repl) to recognize it. In the future, other ancillary buffers (e.g. *cider-error*) will use this variable too instead of re-implementing this locally.
  2. The current approach to remembering point location between screen changes in the inspector is not realiable. For example, it uses a single stack when navigating to prev/next page where ideally it should be a stack of stacks. As a result, the point jumps quite chaotically when using the inspector. I simplified the approach – now, there is only one stack for inspector push/pop operations. For other operations (prev/next page, siblings, non-updating operations), the point is kept in the same place where it is now. In operations that completely re-render the inspector, the point is "reset" to the first inspectable object.

  • You've updated the changelog (if adding/changing user-visible functionality)
@alexander-yakushev alexander-yakushev force-pushed the inspector-point-retention branch 4 times, most recently from 652f123 to 3791a4b Compare March 11, 2025 15:35
(user-error "No %s REPLs in current session \"%s\""
type (car (sesman-current-session 'CIDER)))))

(defvar-local cider--ancillary-buffer-current-repl nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this REPL/connection never changes I'm guessing that the word "current" is redundant here.

@alexander-yakushev alexander-yakushev force-pushed the inspector-point-retention branch from 3791a4b to 2a61c24 Compare March 13, 2025 13:58
@alexander-yakushev alexander-yakushev force-pushed the inspector-point-retention branch from 2a61c24 to 6adf504 Compare March 13, 2025 14:00
@alexander-yakushev alexander-yakushev force-pushed the inspector-point-retention branch from 6adf504 to d9aec38 Compare March 13, 2025 14:05
@alexander-yakushev alexander-yakushev merged commit e125d3e into master Mar 13, 2025
17 of 19 checks passed
@alexander-yakushev alexander-yakushev deleted the inspector-point-retention branch March 13, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants