Skip to content

Conversation

r0man
Copy link
Contributor

@r0man r0man commented Apr 11, 2025

Hello,

this PR adds a new pretty view mode that uses the pretty printer from https://github.com/eerohele/pp via this PR in orchard clojure-emacs/orchard#335. I believe there are no changes needed on the Emacs side.

TODO:

  • Tests are failing because I need a new orchard version on ci, but how?

Open questions:

  • Where should we put the pretty mode in the toggle list? I would put it after normal mode, 2nd position. Right now it is last, hard to reach In my opinion.
  • When drilling down the inspector always switches to normal mode. If I'm in pretty mode I would like to stay there, and I would argue for other modes as well, if possible. right now you have to toggle a ton, to get that behaviour.
    Wdyt?

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • You've updated the README
  • Middleware documentation is up to date
@alexander-yakushev
Copy link
Member

Tests are failing because I need a new orchard version on ci, but how?

We don't have a solution for that right now. So it's usually "merge and publish Orchard first, then merge cider-nrepl". But you can test locally by installing a local Orchard build and specifying that as a dependency for cider-nrepl.

@r0man
Copy link
Contributor Author

r0man commented Apr 14, 2025

Ok, that's what I remembered as well. I'm using the approach you suggested, tests are passing here, and I also fixed the issue I had with the linter. Thanks!

@r0man r0man changed the title Add pretty view mode Add support for pretty printing values in the inspector. Apr 18, 2025
Copy link
Member

@alexander-yakushev alexander-yakushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@alexander-yakushev
Copy link
Member

@r0man Do you want to change anything else or we are good to merge?

@r0man
Copy link
Contributor Author

r0man commented Apr 18, 2025

Hi @alexander-yakushev I think we are good.

@alexander-yakushev alexander-yakushev merged commit 5e40e6a into clojure-emacs:master Apr 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants