Support picking question via name #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wendajiang reviewed Mar 6, 2023
| hey @gotlougit! would you mind merging master and resolving the conflicts? imo the current PR is enough for merging! |
| I noticed there was a different error while running |
clearloop approved these changes Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to leetcode pick which allows users to select a question based on the question name. The question name has to be exactly the same, but given how it is sometimes easier to remember the question name rather than question number in Leetcode, this will still help in ease of use.
Eg.
leetcode pick --name "Two Sum"gets the Two Sum problem from LeetCode. If no name is present, it defaults to finding by ID as before.The rest of the subcommands are exactly the same since it is presumed that the user can just look at the question number from leetcode pick anyway.
README was also changed to reflect this new command type.