fix: Pin @modelcontextprotocol/sdk to a stable version to fix JSON output error #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug that causes the server to output invalid JSON, leading to a
SyntaxErroron the client side.The Problem:
The
package.jsonfile uses a caret^for the@modelcontextprotocol/sdkdependency (^1.17.5). This allowsnpmornpxto automatically install a newer minor version. A recent version of the SDK appears to have a bug that produces malformed JSON when multiple responses are sent in quick succession.The Fix:
This PR pins the
@modelcontextprotocol/sdkdependency to the exact stable version1.17.5by removing the^. This ensures that a known-good version of the SDK is always used, preventing the JSON parsing error.This will resolve issues for users of tools like
gemini-cliwho are experiencingSyntaxError: Expected ',' or ']' after array element in JSONwhen interacting with this MCP server.