Added comments to show $scrollview usage in applications #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was working on an infinite scroll list component today and I could not figure out where to import the
$scrollviewvariable from to use in my view component.After reading the documentation, I found the way, but I implement many things by tweaking the code from provided examples (which are meant to be working out of the box) and I think it would be cool to include a hint in them as well on how to use the plugin in a real application, just to prevent people from having to search through the documentation.
I couldn't decide whether I should've added more context to my comments, so if that is an issue, I can make some further tweaks.
I think this kind of hint would help me but I do not know what is your opinion on the whole thing, so I am leaving it up to you to decide whether this addition is useful or not.