Skip to content

SimSlides Classic for Gazebo classic #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2020
Merged

SimSlides Classic for Gazebo classic #14

merged 2 commits into from
Oct 18, 2020

Conversation

@chapulina
Copy link
Owner

@chapulina chapulina commented Oct 18, 2020

Generalize for other simulators

  • Split functionality into:

    • comon: not simulator specific
    • classic: specific to Gazebo classic

  • Bump required version to Gazebo 11

  • Change executable from simslides to simslides_classic

  • Change plugin from libsimslides to libSimSlidesClassic

Fixes

Used the refactoring to address longstanding issues:

  • Remove "prefix + counter" logic, use full visual names instead
  • Move global variables to a singleton class
  • Disable load dialog for now, it doesn't work with all keyframe types
  • Renamed "slide" to "keyframe" throughout the API
  • Removed "Stop" logic, which was never used
  • "Simslides" -> "SimSlides"
@chapulina
Move files from src to classic and common
0490b2f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
SimSlides Classic for Gazebo classic
8e51028 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 178a692 into main Oct 18, 2020
@chapulina chapulina deleted the classic branch October 18, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@chapulina