Fix wrong typing of TabAction prop #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e4a5ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## main #1497 +/- ## ======================================= Coverage 87.31% 87.31% ======================================= Files 280 280 Lines 3848 3848 Branches 805 805 ======================================= Hits 3360 3360 Misses 415 415 Partials 73 73
☔ View full report in Codecov by Sentry. |
Contributor
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi approved these changes Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Self Checklist
[Component] I wrote a unit test about the implementation.[Component] I wrote a storybook document about the implementation.[Component] I tested the implementation in various browsers.[New Component] I added my username to the correct directory in theCODEOWNERSfile.Related Issue
Fixes #1126
Summary
TabAction은href를 받으면a로, 그렇지 않으면button으로 동작하지만 event handler 에 대한 타입은 항상button에 대한 event handler 로 정의되어 있습니다. 이것을 수정합니다.Details
typescript 에서는 higher order function에 대해 제네릭 타입의 추론이 가능하지만,
forwardRef처럼 반환타입이 추가로 속성(displayName,defaultProps)을 가지게 되면 이것이 제대로 동작하지 않습니다. 참고: https://stackoverflow.com/a/58473012/22224797위에서 제시한 assertion 을 하지 않고
myRef같이 custom 한 ref prop 을 열거나 글로벌하게forwardRef타입을 변경하는 것은 베지어에 적용할 수 없다고 생각하여, assertion 을 해서 아래처럼 타입이 제대로 잡히게 했습니다.As-is
[href 있을 때]
[href 없을 때]
[href 있을 때]
[href 없을 때]
Breaking change or not (Yes/No)
References