Add Walker and Display for Promise objects under debugger locals #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
Collaborator Author
| @boingoing @akroshg please take a look |
| RecyclablePromiseObjectWalker(ScriptContext* pContext, Var instance); | ||
| | ||
| virtual BOOL Get(int i, ResolvedObject* pResolvedObject) override; | ||
| virtual ulong GetChildrenCount() override { return 2; } |
Contributor
There was a problem hiding this comment.
nit: could you comment here on readability on why 2?
Contributor
| overall looks good to me. |
agarwal-sandeep force-pushed the promisewalker branch from b62ee0f to 15016d7 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Promise objects will now show [Promise] fake node with [status] and
[value] as childrens.
[status] is one of undefined/pending/resolved/rejected
[value] is either undefined or the value display.