swb: trivial cleanup #2355
Merged
swb: trivial cleanup #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Annotate "Arguments" fields with FieldNoBarrier, so that the plugin checker is happy. Revert a JavascriptGenerator change Lei accidentally removed (credit to Lei). One StackTrace test config seems incorrect. It contained 2 "compile-flags" and the 2nd overrided 1st, making the test exactly the same as a previous one.
leirocks approved these changes Jan 11, 2017
jianchun pushed a commit that referenced this pull request Jan 11, 2017
Merge pull request #2355 from jianchun:swbtouchup Annotate "Arguments" fields with FieldNoBarrier, so that the plugin checker is happy. Revert a JavascriptGenerator change Lei accidentally removed (credit to Lei). One StackTrace test config seems incorrect. It contained 2 "compile-flags" and the 2nd overrided 1st, making the test exactly the same as a previous one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Annotate "Arguments" fields with FieldNoBarrier, so that the plugin checker
is happy.
Revert a JavascriptGenerator change Lei accidentally removed (credit to
Lei).
One StackTrace test config seems incorrect. It contained 2 "compile-flags"
and the 2nd overrided 1st, making the test exactly the same as a previous
one.