swb,plugin: cleanup, support OSX and plugin arguments #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make the clang plugin work on OSX. OSX note: Must run the same clang binary for which the plugin was built for. e.g.: ``` ./build.sh -n -d --icu=/usr/local/opt/icu4c/include/ \ --cxx=/usr/local/opt/llvm/bin/clang++ \ --cc=/usr/local/opt/llvm/bin/clang \ --wb-check lib/Runtime/Base/FunctionBody.cpp ``` Clean up plugin build script and sources. Add plugin arguments support. Arguments can be directly passed from top level "build.sh". Changed --wb-check default output to "ERROR" only. To output verbose, use plugin argument "-verbose": ``` build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp \ --wb-args=-verbose ``````
Author
| @dotnet-bot test Linux tests please |
Author
| @leirocks Please help CR, thanks! |
Contributor
|
|
Author
| Thanks @digitalinfinity ! |
jianchun pushed a commit that referenced this pull request Oct 31, 2016
…rguments Merge pull request #1847 from jianchun:wbarg Make the clang plugin work on OSX. OSX note: Must run the same clang binary for which the plugin was built for. e.g.: ``` ./build.sh -n -d --icu=/usr/local/opt/icu4c/include/ \ --cxx=/usr/local/opt/llvm/bin/clang++ \ --cc=/usr/local/opt/llvm/bin/clang \ --wb-check lib/Runtime/Base/FunctionBody.cpp ``` Clean up plugin build script and sources. Add plugin arguments support. Arguments can be directly passed from top level "build.sh". Changed --wb-check default output to "ERROR" only. To output verbose, use plugin argument "-verbose": ``` build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp \ --wb-args=-verbose ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make the clang plugin work on OSX.
OSX note: Must run the same clang binary for which the plugin was built for. e.g.:
Clean up plugin build script and sources.
Add plugin arguments support. Arguments can be directly passed from top
level "build.sh".
Changed --wb-check default output to "ERROR" only. To output verbose, use
plugin argument "-verbose":