Skip to content

Conversation

@lgebhardt
Copy link
Member

@lgebhardt lgebhardt commented Feb 4, 2022

Cached resources were returning relationship data elements if when the resource was first accessed the relationship included data element. This removes the data element from the cached resource fragment.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
@lgebhardt lgebhardt requested a review from dgeb February 4, 2022 19:14
@lgebhardt lgebhardt merged commit 3fda2cf into release-0-10 Feb 4, 2022
@lgebhardt lgebhardt deleted the dont_cache_relationship_data branch February 4, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants