EngineClient: EnginePort improvements #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This patch introduces several changes related to EnginePort. Remove dependency with Task: indeed, as an EngineClient, an EnginePort should not have any dependency with Task, so it can be used internally by workers before a Task is even defined. Generate ev_start event when an EnginePort is starting, so that we can be notified with registered EnginePort when the Engine is starting. Move 'port_qlimit' config default to an [engine] section in defaults.conf so that it doesn't depend on Task anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This patch introduces several changes related to EnginePort.
Remove dependency with Task: indeed, as an EngineClient, an EnginePort
should not have any dependency with Task, so it can be used internally
by workers before a Task is even defined.
Generate ev_start event when an EnginePort is starting, so that we can
be notified with registered EnginePort when the Engine is starting.
Move 'port_qlimit' config default to an [engine] section in
defaults.conf so that it doesn't depend on Task anymore.