Clush: use os.read() in stdin thread #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Work around Python 3 threading bug https://bugs.python.org/issue42717 when stdin is blocked in read() at interpreter shutdown by using select() before read(). Fixes #461.
Collaborator
| Don't know if i understood all the side effects of this patch bug would be nice to have a test for that tricky case |
martinetd reviewed Oct 22, 2021
Co-authored-by: Dominique Martinet <asmadeus@codewreck.org>
Collaborator Author
| testing travis |
Substitute standard streams with TemporaryFile objects instead of BytesIO, so we get a valid fileno() method for testing.
martinetd approved these changes Oct 28, 2021
Work around Python 3 threading bug https://bugs.python.org/issue42717 when stdin is blocked in read() at interpreter shutdown by using os.read() with stdin file descriptor. Fixes #461.
thiell changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Work around Python 3 threading bug https://bugs.python.org/issue42717
when stdin is blocked in read() at interpreter shutdown by using
select() before read().
Fixes #461.