fix array types #24
Merged
fix array types #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes some consistency issues where ObjectLiteral types where being emitted as Prokind.Type when they were actual objects that conform to a specific type
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Thanks a lot, looks great. Will try to merge it today or tomorrow . can you give some examples of casted object literals |
| Sure. Here is the before and after. The before is marking the kind as an interface but it's actually an Object thats casted to a specific interface. Or here is another example where the object is being defined to conforming to a specific interface and is being marked as such. Here is this PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #20
This fixes issues where holey arrays or object literals within an array where not branded with a
PropKind. That said it appears that casted object literals where being emitted with aPropKind.TypeorPropKind.Interfacewhich does not seem correct since these values exist at runtime.