Check object is actual array before calling count to prevent warnings #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jschroed91 requested changes Apr 1, 2020
| Let me know if you need anything else on it. |
| @jschroed91 Did you need anything else done on this PR? |
| @jschroed91 Do you have an update for when you think this may be merged? |
SavageTiger reviewed Jan 25, 2021
| { | ||
| while (true) { | ||
| if (!is_countable($words) || count($words) == 0) { | ||
| if (!is_array($words) || count($words) == 0) { |
There was a problem hiding this comment.
Hi @daum could you please do strict type checking here? (using ===) and rebase this PR on the latest master
| Hi 👋 Its been a while, but I have looked into this PR. However I am a bit confused about it, since the preposed changes are both in the If I am mistaken, feel free to let me know. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As of PHP 7.2 if you pass count(null) it'll emit a warning of
Parameter must be an array or an object that implements Countable in …This makes sure that the$wordsis actually an array and not null, so it is in fact countable.