Fix Unicode handling in table diff by encoding non-ASCII chars as numeric entities #137
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously,
TableDiff::createDocumentWithHtml()
attempted to normalize text forDOMDocument::loadHTML()
by passing it throughhtmlentities()
andiconv('UTF-8', 'ISO-8859-1//IGNORE', ...)
. This caused non-ASCII characters (e.g. emoji, Cyrillic, CJK) that are neither representable HTML named entities nor in ISO-8859-1 to be dropped entirely.This patch replaces that logic with a call to
mb_encode_numericentity()
to convert all non-ASCII Unicode codepoints (U+0080 – U+10FFFF) into decimal HTML numeric entities. This ensures that the full Unicode range is preserved and parsed correctly byDOMDocument
, which otherwise defaults to ISO-8859-1.Resolves #136