- Notifications
You must be signed in to change notification settings - Fork 317
Move to standalone components #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Move to standalone components #3155
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@Akshat55 what is your stance or policy regarding backwards compatibility on the next branch? There are a lot of interesting features in current angular releases, also with regards to signals and zoneless. Would it be okay to make the next branch angular 20+ and drop backwards compatibility? The version numbers here (v5, ...) does not align with carbon upstream (which is at 11) nor with angular (20), so if you have no internal policy of supporting all versions of angular, maybe a clear cut and upgrade with the next branch would do it as well? |
Hey @georgmu, we need backwards compatibility, because many teams have massive applications and are slow to upgrade to latest angular versions + features. However, this should be taken care of with v5 - just means we will have to support v5 until Carbon 12 is released or have enough teams migrated to use v6. I would be okay with Angular 20 as next branch, it would have to be another PR though. This PR will take some time to review/merge - I want to have some teams test it possible. I'll also be testing locally via linking. |
To further support angular with zone.js > 0.14 without dependency resolution problems we maybe have to use the next branch (and version 6) for angular 19/20+ support. I'm also working on this atm and will be opening up at least tow PRs more in the next few days/weeks with the changes seperated in logical chunks.
Thank you very much for taking your time testing and reviewing it. |
4d43533
to 4c07f15
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on both module-based & standalone apps that use MOST of the components, everything seems to be working fine!
There were a few import errors, caused by commenting out/removing module exports from index file.
Main concern were some of the common services, I think we can simplify them by providing them in root.
approach but the standalone approach
provider and just provide them in root
4c07f15
to ca7c47b
Compare
Updates all components to standalone components
It got a bit big but I've tried to move all components to standalone components. My test-setup is a bit confused with the changes but it works with the tests and storybook.
Changelog
Changed
I'm on vacation for the next two weeks but will look into this from time to time.