Skip to content

Conversation

tom-wegener
Copy link

Updates all components to standalone components

It got a bit big but I've tried to move all components to standalone components. My test-setup is a bit confused with the changes but it works with the tests and storybook.

Changelog

Changed

  • updates all components to standalone components
  • updates all tests to work with the standalone components
  • updates storybook to work with standalone components
  • keeps the module functionality

I'm on vacation for the next two weeks but will look into this from time to time.

@tom-wegener tom-wegener requested a review from a team as a code owner July 4, 2025 07:51
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit ca7c47b
🔍 Latest deploy log https://app.netlify.com/projects/carbon-components-angular/deploys/68b80659f26f7f0008dca22f
😎 Deploy Preview https://deploy-preview-3155--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for carbon-angular-next ready!

Name Link
🔨 Latest commit ca7c47b
🔍 Latest deploy log https://app.netlify.com/projects/carbon-angular-next/deploys/68b806596919e10008858220
😎 Deploy Preview https://deploy-preview-3155--carbon-angular-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@georgmu
Copy link

georgmu commented Jul 14, 2025

@Akshat55 what is your stance or policy regarding backwards compatibility on the next branch? There are a lot of interesting features in current angular releases, also with regards to signals and zoneless.

Would it be okay to make the next branch angular 20+ and drop backwards compatibility? The version numbers here (v5, ...) does not align with carbon upstream (which is at 11) nor with angular (20), so if you have no internal policy of supporting all versions of angular, maybe a clear cut and upgrade with the next branch would do it as well?

@Akshat55
Copy link
Contributor

Hey @georgmu, we need backwards compatibility, because many teams have massive applications and are slow to upgrade to latest angular versions + features. However, this should be taken care of with v5 - just means we will have to support v5 until Carbon 12 is released or have enough teams migrated to use v6.

I would be okay with Angular 20 as next branch, it would have to be another PR though.

This PR will take some time to review/merge - I want to have some teams test it possible. I'll also be testing locally via linking.

@tom-wegener
Copy link
Author

Hey @georgmu, we need backwards compatibility, because many teams have massive applications and are slow to upgrade to latest angular versions + features. However, this should be taken care of with v5 - just means we will have to support v5 until Carbon 12 is released or have enough teams migrated to use v6.

I would be okay with Angular 20 as next branch, it would have to be another PR though.

To further support angular with zone.js > 0.14 without dependency resolution problems we maybe have to use the next branch (and version 6) for angular 19/20+ support. I'm also working on this atm and will be opening up at least tow PRs more in the next few days/weeks with the changes seperated in logical chunks.

This PR will take some time to review/merge - I want to have some teams test it possible. I'll also be testing locally via linking.

Thank you very much for taking your time testing and reviewing it.

@tom-wegener tom-wegener force-pushed the feature/standalone-gh-mr branch from 4d43533 to 4c07f15 Compare July 24, 2025 14:36
@tom-wegener tom-wegener requested a review from Akshat55 August 29, 2025 07:53
Copy link
Contributor

@Akshat55 Akshat55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on both module-based & standalone apps that use MOST of the components, everything seems to be working fine!

There were a few import errors, caused by commenting out/removing module exports from index file.

Main concern were some of the common services, I think we can simplify them by providing them in root.

@tom-wegener tom-wegener force-pushed the feature/standalone-gh-mr branch from 4c07f15 to ca7c47b Compare September 3, 2025 09:11
@tom-wegener tom-wegener requested a review from Akshat55 September 3, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants