Fix white select area in windows #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| I realized that replacing the backslash problem on the server solved the issue for pdfs that were already uploaded but any new pdfs uploaded would not work. By making the chance occur when the select area library tried to access it seems to fix the problem for previous uploads and future uploads. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CLOSES #5, #82, #142
When running Excalibur in windows, selecting the area where the tables exist whether by your mouse or by autodetect tables shows a white box rather than the document behind it.
Looking at your terminal shows this is because of a 404 as the server can not find the image to show.
For some reason that I have not figured out on windows only, the image path gets mangled and some of the forward slashes are instead replaces with backslashes.
This resolves that issue.