fix: add note about baseElement removed from render #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Swor71 reviewed Sep 3, 2020
Swor71 left a comment
Swor71 left a comment There was a problem hiding this comment.
- typo in
because - I would also change
although we advise not doing so.toalthough we advise against doing so.as it sounds more natural. (just an opinion, tho)
Member Author
| @Swor71 thanks! |
Swor71 approved these changes Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #513 by mentioning removal of
baseElementin the migration guide. We could add it to the library, but there's little to no push on that feature. Happy to introduce it later, if requested.Test plan
None