fix: toBeDisabled now also evaluates disabled prop when element is Text #1802
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1801 by ensuring
Textcomponents with thedisabledprop are correctly identified as disabled bycomputeAriaDisabled.Previously,
computeAriaDisableddidn't check for thedisabledprop onTextelements, causing queries likegetByRole('text', { disabled: true })to fail. The change adds a check to returntruewhenisHostText(element)andprops.disabledare both true, aligningreact-native-testing-library's behavior with expected accessibility states.Test plan
New unit tests have been added for
computeAriaDisabledto verify this change. These tests cover:Textcomponent withdisabled={true}: AssertscomputeAriaDisabledreturnstrue.Textcomponent withoutdisabledprop ordisabled={false}: AssertscomputeAriaDisabledreturnsfalse.Existing
TextInputbehavior: Ensures non-editableTextInputcomponents are still correctly identified as disabled.aria-disabledandaccessibilityState.disabledprops: Verifies these existing checks continue to function.The new
computeAriaDisabledtests should pass, demonstrating correct handling of thedisabledprop onTextcomponents.