fix: js-only libraries have codegen config #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
atlj force-pushed the @atlj/fix-js-only-template-codegen branch from d2c4b1d to 0e80065 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #754
JS-only libraries were setting the new architecture flag on. While this is not a preferable mental model, we had some code associated with codegen that checked this flag. With this PR, JS-only libraries will set this flag to false. This is not an optimal solution but we will fully drop this flag with the deprecation of the legacy arch in the upcoming months.
Test plan
codegentarget isn't added to bob targets inpackage.jsoncodegenConfiginpackage.jsonyarn prepareworks.