fix: bob codegen deletes view specs when codegen type is all #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
satya164 reviewed Dec 24, 2024
packages/react-native-builder-bob/src/utils/patchCodegenAndroidPackage.ts Show resolved Hide resolved
| Thank you for fixing this!! |
| Any updates on when this one can get merged? |
atlj force-pushed the @atlj/patch-view-spec-codegen branch from d5bd73b to b43403f Compare 
| @sidorchukandrew sorry for the late reply, I'm working on it now 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #728
The codegen patcher script was deleting the whole
facebooknamespace when the codegen type was all or module. This was not a problem when the type was module but when the type was all, view manager specs were also getting removed.sTest plan
yarn bob build --target codegenandroid/generated/java/com/facebook/reactexists and has view manager specs