Skip to content

Conversation

@atlj
Copy link
Collaborator

@atlj atlj commented Nov 21, 2024

Summary

We were using type: "all" in codegenConfig for all types of libraries. @cipolleschi recommended us to use proper types instead in this thread. This updates the templates to use the proper types

Test plan

Modules

  1. Create a new arch supported module library
  2. Go to the package.json and make sure codegenConfig.type is "modules"
  3. Make sure the library builds and runs fine with the new architecture

Components a.k.a views

  1. Create a new arch supported view/component
  2. Go to the package.json and make sure codegenConfig.type is "components"
    1. Make sure the library builds and runs fine with the new architecture
@atlj atlj changed the title fix: proper codegen types fix: use proper codegen types Nov 21, 2024
Copy link

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. all is still a valid type, but should be used when a libraries exposes at least a module and at least a component.

But this is an advanced use case that perhaps users can apply themselves while developing, there is no need to control it in the template probably.

@atlj atlj force-pushed the @atlj/use-proper-codegen-types branch from 44456a5 to 9acb1fc Compare November 29, 2024 09:08
@atlj atlj merged commit c143bab into main Nov 29, 2024
17 of 29 checks passed
@atlj atlj deleted the @atlj/use-proper-codegen-types branch November 29, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants