refactor(crnl): split the index file #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
atlj commented Nov 16, 2024
| import fs from 'fs-extra'; | ||
| import type { ExampleApp } from '../input'; | ||
| | ||
| export async function getDependencyVersionsFromExample( |
There was a problem hiding this comment.
Suggested change
| export async function getDependencyVersionsFromExample( | |
| export async function getDependencyVersionsFromExampleApp( |
| folder: string, | ||
| exampleAppType: ExampleApp | ||
| ) { | ||
| // Set `react` and `react-native` versions of root `package.json` from example `package.json` |
There was a problem hiding this comment.
Suggested change
| // Set `react` and `react-native` versions of root `package.json` from example `package.json` |
atlj force-pushed the @atlj/refactor-crnl-main branch from ef29e22 to ffd2eed Compare 
atlj force-pushed the @atlj/refactor-crnl-main branch from ffd2eed to ffc4517 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
The previous
index.tsfile ofcreate-react-native-librarywas too long and complicated to maintain. This PR splits the file a bitTest plan