fix: make sure react-native.config.json is shipped with each library Fixes #647 #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
atlj approved these changes Oct 11, 2024
| LGTM Thanks for sending this! |
Closed
2 tasks
| @migueldaipre You are right. Wasn't thinking straight after hours of debugging this. Should have copied and pasted it from my library! Fixed in #659 |
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
With the new introduction of a90142f#diff-4282562f42ade49c2eb46dee36bcbb7987322efec211330f48387a10e5514678R206 that adds
includeGeneratedCode,react-native.config.jsneeds to be shipped with the NPM module to signal what directory to use.Test plan
Tested
react-native-vector-iconswhere I discovered this issue against my project.