improve doc #6
Closed
improve doc #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I guess there is no src/index.js because we are writing TS ;) it's also found here: https://github.com/react-navigation/core/blob/master/package.json#L6
3imed-jaberi approved these changes Jan 18, 2020
satya164 reviewed Jan 19, 2020
| "main": "lib/commonjs/index.js", | ||
| "module": "lib/module/index.js", | ||
| "react-native": "src/index.js", | ||
| "react-native": "lib/module/index.js", |
There was a problem hiding this comment.
Thanks for the PR. This should be index.tsx for TypeScript projects (unless you're supporting old versions of React Native without TypeScript support):
Suggested change
| "react-native": "lib/module/index.js", | |
| "react-native": "src/index.tsx", |
| Closing as the example is now fixed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I guess there is no src/index.js because we are writing TS ;)
it's also found here: https://github.com/react-navigation/core/blob/master/package.json#L6