Add abiFilters to the native template #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
atlj approved these changes Apr 26, 2024
| Looks like this is failing some of the Android workflows. Can you take a look at them? |
| @atlj Looks like all CIs failed because of |
satya164 requested changes May 16, 2024
packages/create-react-native-library/templates/native-common/android/build.gradle Outdated Show resolved Hide resolved
| @tomekzaw seems it's failing for all of the Android builds so it doesn't seem like flaky tests but an issue with the change. |
…ndroid/build.gradle Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
In the native template
abiFiltersis missing fromexternalNativeBuildblock. This means that the library would be built for every available ABI when building the application, even if the application itself is being built for a specific one. This is not that problematic (besides taking more time) when using React Native aar, but when building RN from source the core.sofiles will be built for that specific ABI. In case the library depends on a.sofile, it would fail at the linking stage due to missing.sofor the remaining ABIs.Test plan
See