Skip to content

feat(aar): added configurable bundle name #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2019
Merged

feat(aar): added configurable bundle name #5

merged 1 commit into from
Jun 28, 2019

Conversation

@Johan-dutoit
Copy link
Contributor

Summary

This adds the ability to change the aar bundle name bob uses. Instead of always expecting android.aar (it's still the default).
@satya164
Copy link
Member

@matt-oakes wdyt?
@satya164 satya164 requested a review from matt-oakes June 25, 2019 10:24
matt-oakes
matt-oakes approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@matt-oakes matt-oakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:
@satya164 satya164 merged commit 6f04c04 into callstack:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Johan-dutoit @satya164 @matt-oakes