feat(legacy view template): extract view to a separate file #375
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Closes #370
Inspecting the codebase I've spotted that all of the view templates have the View initialized on a different file except the
legacy viewtemplate. Having the view initialized in theindex.tsxreduces the DX as anytime you make changes to the 'index.tsxfile, you will getInvariant Violation: Tried to register two views with the same name` error. This PR addresses these issues.Test plan
create-react-native-libraryand select these options:src/<Your Project Name>ViewNativeComponent.tsexists with proper codeindex.tsxindex.tsx, theInvariant Violation: Tried to register two views with the same nameerror doesn't appear.