feat: preserve casing and handle npm namespace scenario #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Before I fix the tests, I want to get your approval |
wood1986 force-pushed the features/preserve-casing branch from 1749c9f to 63911e2 Compare | ping |
satya164 requested changes Sep 16, 2022
There was a problem hiding this comment.
Hello, thank you for the PR. Can you add some comments above the code changes describing why we're doing it and what each of the replace is doing? I think currently it's not obvious just by reading the code why we're changing this.
Happy to merge after adding some comments
wood1986 force-pushed the features/preserve-casing branch 2 times, most recently from 1084e64 to c1bb3c5 Compare 
wood1986 force-pushed the features/preserve-casing branch from c1bb3c5 to f707de8 Compare 
| I'll work on getting this merged tomorrow |
satya164 force-pushed the main branch 2 times, most recently from b94e81b to cf3f675 Compare satya164 added a commit that referenced this pull request Oct 23, 2022
closes #250 Co-authored-by: wood1986 <5212215+wood1986@users.noreply.github.com>
| I refactored and implemented this in 4993bc9 trying to preserve the namespace and spacing while still avoiding invalid input. I have added you as co-author of the commit since it's based on your work. Thanks again for the PR. |
| Thanks for the merge |
okwasniewski pushed a commit that referenced this pull request Nov 4, 2022
closes #250 Co-authored-by: wood1986 <5212215+wood1986@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
For the inputs without namespace and
react-native-scenarioFor the inputs with namespace scenario
Test plan