Skip to content

refactor: move eslintIgnore to package.json #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix: add support for 'jsx' file extention
merged 2 commits into from
Mar 4, 2020
Merged

refactor: move eslintIgnore to package.json #23

merged 2 commits into from
Mar 4, 2020

Conversation

@safaiyeh
Copy link
Contributor

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
@safaiyeh safaiyeh requested a review from satya164 February 26, 2020 01:50
satya164
satya164 requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. But we already ignore node_modules/ here: https://github.com/react-native-community/bob/blob/master/templates/library/%24.eslintignore
@safaiyeh
Copy link
Contributor Author

safaiyeh commented Feb 26, 2020 •
edited
Loading

Oh cool, it wasn't generated when I used it. Tried with the latest and it is all good now. Thanks!
@safaiyeh safaiyeh closed this Feb 26, 2020
@safaiyeh safaiyeh deleted the safaiyeh-patch-1 branch February 26, 2020 19:33
@satya164
Copy link
Member

Maybe we can move it to package.json regardless. I thought that it was not possible to have it in package.json 😅
@safaiyeh safaiyeh restored the safaiyeh-patch-1 branch February 27, 2020 00:17
@safaiyeh safaiyeh reopened this Feb 27, 2020
@safaiyeh
Copy link
Contributor Author

Alright! I'll move it over, I'll update this tonight
@safaiyeh
Copy link
Contributor Author

safaiyeh commented Mar 3, 2020

@satya164 updated!
@satya164 satya164 changed the title Add eslintIgnore to package.json refactor: move eslintIgnore to package.json Mar 4, 2020
@satya164 satya164 merged commit 703355d into master Mar 4, 2020
@satya164 satya164 deleted the safaiyeh-patch-1 branch March 4, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@safaiyeh @satya164