Skip to content

feat: add abilty to generate a react-native project #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix: add support for 'jsx' file extention
merged 1 commit into from
Feb 9, 2020
Merged

feat: add abilty to generate a react-native project #21

merged 1 commit into from
Feb 9, 2020

Conversation

@satya164
Copy link
Member

@satya164 satya164 commented Feb 8, 2020 •
edited
Loading

Kapture 2020-02-09 at 4 49 57
@satya164 satya164 force-pushed the @satya164/library-template branch 11 times, most recently from a5012fc to dd12e41 Compare February 9, 2020 07:07
thymikee
thymikee reviewed Feb 9, 2020
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think this is a good base that could be further extended. However what worries me is the maintenance cost, as the templates will need to change with every major RN bump. If you could think of automating generating templates with a script or something, that would help the project in the long run
@satya164 satya164 force-pushed the @satya164/library-template branch from dd12e41 to 0830cdc Compare February 9, 2020 08:53
@satya164 satya164 merged commit a25c16e into master Feb 9, 2020
@satya164 satya164 deleted the @satya164/library-template branch February 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@satya164 @thymikee