Skip to content

Conversation

@troZee
Copy link
Contributor

@troZee troZee commented Nov 13, 2020

Summary

After merging this feature, bob includes both Functional and UI native modules upon bootstraping. Not all projects require both types though, so additional command to select all/one/none would be great to have.

  • Added a separate template folders (native-view-library, objc-view-library, swift-view-library) to add only necessary files to the generated project
  • Added new type ModuleType to distinguish, what type of module dev would like to generate
  • The mixed case (view module with native module) has not been added here, because in most cases ppl create only a separate modules (We can consider to implement it in separate PR)

Closes #93

Test plan

  • run below command for all types
../bob/bin/bob create test-project
  • run yarn bootstrap and then yarn android & yarn ios
  • check, if all projects has been generated correctly

Screenshots

Native View Module
Screen Shot 2020-11-13 at 1 05 29 PM

Native module
Screen Shot 2020-11-13 at 12 51 01 PM

Added below two options:
Screen Shot 2020-11-13 at 3 00 33 PM

@troZee troZee requested review from krizzu and satya164 November 13, 2020 14:08
@troZee troZee force-pushed the @troZee/native-module-cli-93 branch from 8a04e43 to 97da122 Compare November 17, 2020 12:10
@troZee troZee marked this pull request as ready for review November 17, 2020 12:11
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@satya164 satya164 changed the title Additional command to select Native Module type refactor: add separate option to generate view modules Dec 16, 2020
@satya164 satya164 merged commit 4359b83 into master Dec 16, 2020
@satya164 satya164 deleted the @troZee/native-module-cli-93 branch December 16, 2020 13:08
@troZee troZee changed the title refactor: add separate option to generate view modules feat: add separate option to generate view modules Dec 22, 2020
@troZee troZee removed the request for review from krizzu December 22, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants